redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: imx-drm: imx-hdmi: clean up hdmi_phy_wait_i2c_done

Browse source 
Simplify hdmi_phy_wait_i2c_done so the call to hdmi_readb is
only done in one place. Also check for timout before waiting
as suggested by Troy Kisky.
This also fixes a checkpatch warning.

Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Emil Renner Berthing 2014-03-30 00:21:21 +01:00 committed by Greg Kroah-Hartman
parent 9e74d2926a
commit 0e6bcf3a15
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/staging/imx-drm/imx-hdmi.c
View file

@ -659,13 +659,10 @@ static inline void hdmi_phy_test_dout(struct imx_hdmi *hdmi,
static bool hdmi_phy_wait_i2c_done(struct imx_hdmi *hdmi, int msec)
{
unsigned char val = 0;
val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3;
while (!val) {
udelay(1000);
while ((hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3) == 0) {
if (msec-- == 0)
return false;
val = hdmi_readb(hdmi, HDMI_IH_I2CMPHY_STAT0) & 0x3;
udelay(1000);
}
return true;
}