net: openvswitch: ensure LSE is pullable before reading it
[ Upstream commit5.4-rM2-2.2.x-imx-squashed43c13605ba
] when openvswitch is configured to mangle the LSE, the current value is read from the packet dereferencing 4 bytes at mpls_hdr(): ensure that the label is contained in the skb "linear" area. Found by code inspection. Fixes:d27cf5c59a
("net: core: add MPLS update core helper and use in OvS") Signed-off-by: Davide Caratti <dcaratti@redhat.com> Link: https://lore.kernel.org/r/aa099f245d93218b84b5c056b67b6058ccf81a66.1606987185.git.dcaratti@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
ba203b92a8
commit
1086f78906
|
@ -196,6 +196,9 @@ static int set_mpls(struct sk_buff *skb, struct sw_flow_key *flow_key,
|
|||
__be32 lse;
|
||||
int err;
|
||||
|
||||
if (!pskb_may_pull(skb, skb_network_offset(skb) + MPLS_HLEN))
|
||||
return -ENOMEM;
|
||||
|
||||
stack = mpls_hdr(skb);
|
||||
lse = OVS_MASKED(stack->label_stack_entry, *mpls_lse, *mask);
|
||||
err = skb_mpls_update_lse(skb, lse);
|
||||
|
|
Loading…
Reference in New Issue