redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

netfilter: xt_TCPMSS: correct return value in tcpmss_mangle_packet 

In commit b396966c4 (netfilter: xt_TCPMSS: Fix missing fragmentation handling),
I attempted to add safe fragment handling to xt_TCPMSS.  However, Andy Padavan
of Project N56U correctly points out that returning XT_CONTINUE in this
function does not work.  The callers (tcpmss_tg[46]) expect to receive a value
of 0 in order to return XT_CONTINUE.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
hifive-unleashed-5.1
Phil Oester 2013-09-01 08:32:21 -07:00 committed by Pablo Neira Ayuso
parent 7cc9eb6ef7
commit 1205e1fa61
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/netfilter/xt_TCPMSS.c
View File

@ -60,7 +60,7 @@ tcpmss_mangle_packet(struct sk_buff *skb,
/* This is a fragment, no TCP header is available */
if (par->fragoff != 0)
return XT_CONTINUE;
return 0;
if (!skb_make_writable(skb, skb->len))
return -1;