fbdev: via-gpio: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
33203f5b94
commit
13e676be08
|
@ -142,7 +142,7 @@ static int via_gpio_get(struct gpio_chip *chip, unsigned int nr)
|
||||||
gpio = cfg->active_gpios[nr];
|
gpio = cfg->active_gpios[nr];
|
||||||
reg = via_read_reg(VIASR, gpio->vg_port_index);
|
reg = via_read_reg(VIASR, gpio->vg_port_index);
|
||||||
spin_unlock_irqrestore(&cfg->vdev->reg_lock, flags);
|
spin_unlock_irqrestore(&cfg->vdev->reg_lock, flags);
|
||||||
return reg & (0x04 << gpio->vg_mask_shift);
|
return !!(reg & (0x04 << gpio->vg_mask_shift));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue