of: unittest: kmemleak in of_unittest_overlay_high_level()
kmemleak reports several memory leaks from devicetree unittest.
This is the fix for problem 3 of 5.
of_unittest_overlay_high_level() failed to kfree the newly created
property when the property named 'name' is skipped.
Fixes: 39a751a4cb
("of: change overlay apply input data from unflattened to FDT")
Reported-by: Erhard F. <erhard_f@mailbox.org>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
alistair/sensors
parent
216830d241
commit
145fc138f9
|
@ -3094,8 +3094,11 @@ static __init void of_unittest_overlay_high_level(void)
|
||||||
goto err_unlock;
|
goto err_unlock;
|
||||||
}
|
}
|
||||||
if (__of_add_property(of_symbols, new_prop)) {
|
if (__of_add_property(of_symbols, new_prop)) {
|
||||||
|
kfree(new_prop->name);
|
||||||
|
kfree(new_prop->value);
|
||||||
|
kfree(new_prop);
|
||||||
/* "name" auto-generated by unflatten */
|
/* "name" auto-generated by unflatten */
|
||||||
if (!strcmp(new_prop->name, "name"))
|
if (!strcmp(prop->name, "name"))
|
||||||
continue;
|
continue;
|
||||||
unittest(0, "duplicate property '%s' in overlay_base node __symbols__",
|
unittest(0, "duplicate property '%s' in overlay_base node __symbols__",
|
||||||
prop->name);
|
prop->name);
|
||||||
|
|
Loading…
Reference in New Issue