redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: speakup: Use time_after_eq to compare jiffies in speakup_keypc.c 

The following patch fixes the checkpatch.pl warning:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends

Signed-off-by: Esra Altintas <es.altintas@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Esra Altintas 2014-10-08 14:32:10 +03:00 committed by Greg Kroah-Hartman
parent ad96f37f06
commit 146ea83566
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/speakup/speakup_keypc.c
View File

@ -229,7 +229,7 @@ spin_lock_irqsave(&speakup_info.spinlock, flags);
ch = PROCSPEECH;
outb_p(ch, synth_port);
SWAIT;
if ((jiffies >= jiff_max) && (ch == SPACE)) {
if (time_after_eq(jiffies, jiff_max) && (ch == SPACE)) {
timeout = 1000;
while (synth_writable())
if (--timeout <= 0)