1
0
Fork 0

TTY:vt: convert remain take_over_console's users to do_take_over_console

Impact:
1:convert all remain take_over_console to do_take_over_console
2:update take_over_console to do_take_over_console in comment

Commit dc9641895a ("vt: delete unneeded functions
register_con_driver|take_over_console") delete take_over_console,
but forget to convert remain take_over_console's users to new API
do_take_over_console, this patch fix it.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Wang YanQing <udknight@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Wang YanQing 2013-05-21 13:15:12 +08:00 committed by Greg Kroah-Hartman
parent 4898e640ca
commit 155957f56c
11 changed files with 43 additions and 20 deletions

View File

@ -61,7 +61,9 @@ locate_and_init_vga(void *(*sel_func)(void *, void *))
/* Set the VGA hose and init the new console. */ /* Set the VGA hose and init the new console. */
pci_vga_hose = hose; pci_vga_hose = hose;
take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1); console_lock();
do_take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
console_unlock();
} }
void __init void __init

View File

@ -117,7 +117,9 @@ common_shutdown_1(void *generic_ptr)
if (in_interrupt()) if (in_interrupt())
irq_exit(); irq_exit();
/* This has the effect of resetting the VGA video origin. */ /* This has the effect of resetting the VGA video origin. */
take_over_console(&dummy_con, 0, MAX_NR_CONSOLES-1, 1); console_lock();
do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES-1, 1);
console_unlock();
#endif #endif
pci_restore_srm_config(); pci_restore_srm_config();
set_hae(srm_hae); set_hae(srm_hae);

View File

@ -257,7 +257,9 @@ static int __init bcm1480_pcibios_init(void)
register_pci_controller(&bcm1480_controller); register_pci_controller(&bcm1480_controller);
#ifdef CONFIG_VGA_CONSOLE #ifdef CONFIG_VGA_CONSOLE
take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1); console_lock();
do_take_over_console(&vga_con, 0, MAX_NR_CONSOLES-1, 1);
console_unlock();
#endif #endif
return 0; return 0;
} }

View File

@ -283,7 +283,9 @@ static int __init sb1250_pcibios_init(void)
register_pci_controller(&sb1250_controller); register_pci_controller(&sb1250_controller);
#ifdef CONFIG_VGA_CONSOLE #ifdef CONFIG_VGA_CONSOLE
take_over_console(&vga_con, 0, MAX_NR_CONSOLES - 1, 1); console_lock();
do_take_over_console(&vga_con, 0, MAX_NR_CONSOLES - 1, 1);
console_unlock();
#endif #endif
return 0; return 0;
} }

View File

@ -155,7 +155,7 @@ void __init setup_arch(char **cmdline_p)
#endif #endif
#if defined(CONFIG_VT) && defined(CONFIG_DUMMY_CONSOLE) #if defined(CONFIG_VT) && defined(CONFIG_DUMMY_CONSOLE)
conswitchp = &dummy_con; /* we use take_over_console() later ! */ conswitchp = &dummy_con; /* we use do_take_over_console() later ! */
#endif #endif
} }

View File

@ -3592,7 +3592,7 @@ EXPORT_SYMBOL_GPL(do_unregister_con_driver);
* when a driver wants to take over some existing consoles * when a driver wants to take over some existing consoles
* and become default driver for newly opened ones. * and become default driver for newly opened ones.
* *
* take_over_console is basically a register followed by unbind * do_take_over_console is basically a register followed by unbind
*/ */
int do_take_over_console(const struct consw *csw, int first, int last, int deflt) int do_take_over_console(const struct consw *csw, int first, int last, int deflt)
{ {

View File

@ -208,7 +208,7 @@ sisusbcon_init(struct vc_data *c, int init)
struct sisusb_usb_data *sisusb; struct sisusb_usb_data *sisusb;
int cols, rows; int cols, rows;
/* This is called by take_over_console(), /* This is called by do_take_over_console(),
* ie by us/under our control. It is * ie by us/under our control. It is
* only called after text mode and fonts * only called after text mode and fonts
* are set up/restored. * are set up/restored.
@ -273,7 +273,7 @@ sisusbcon_deinit(struct vc_data *c)
struct sisusb_usb_data *sisusb; struct sisusb_usb_data *sisusb;
int i; int i;
/* This is called by take_over_console() /* This is called by do_take_over_console()
* and others, ie not under our control. * and others, ie not under our control.
*/ */
@ -1490,8 +1490,9 @@ sisusb_console_init(struct sisusb_usb_data *sisusb, int first, int last)
mutex_unlock(&sisusb->lock); mutex_unlock(&sisusb->lock);
/* Now grab the desired console(s) */ /* Now grab the desired console(s) */
ret = take_over_console(&sisusb_con, first - 1, last - 1, 0); console_lock();
ret = do_take_over_console(&sisusb_con, first - 1, last - 1, 0);
console_unlock();
if (!ret) if (!ret)
sisusb->haveconsole = 1; sisusb->haveconsole = 1;
else { else {
@ -1535,11 +1536,14 @@ sisusb_console_exit(struct sisusb_usb_data *sisusb)
if (sisusb->haveconsole) { if (sisusb->haveconsole) {
for (i = 0; i < MAX_NR_CONSOLES; i++) for (i = 0; i < MAX_NR_CONSOLES; i++)
if (sisusb->havethisconsole[i]) if (sisusb->havethisconsole[i]) {
take_over_console(&sisusb_dummy_con, i, i, 0); console_lock();
do_take_over_console(&sisusb_dummy_con, i, i, 0);
console_unlock();
/* At this point, con_deinit for all our /* At this point, con_deinit for all our
* consoles is executed by take_over_console(). * consoles is executed by do_take_over_console().
*/ */
}
sisusb->haveconsole = 0; sisusb->haveconsole = 0;
} }

View File

@ -873,7 +873,7 @@ static int set_con2fb_map(int unit, int newidx, int user)
/* /*
* Low Level Operations * Low Level Operations
*/ */
/* NOTE: fbcon cannot be __init: it may be called from take_over_console later */ /* NOTE: fbcon cannot be __init: it may be called from do_take_over_console later */
static int var_to_display(struct display *disp, static int var_to_display(struct display *disp,
struct fb_var_screeninfo *var, struct fb_var_screeninfo *var,
struct fb_info *info) struct fb_info *info)

View File

@ -585,10 +585,14 @@ static const struct consw mda_con = {
int __init mda_console_init(void) int __init mda_console_init(void)
{ {
int err;
if (mda_first_vc > mda_last_vc) if (mda_first_vc > mda_last_vc)
return 1; return 1;
console_lock();
return take_over_console(&mda_con, mda_first_vc-1, mda_last_vc-1, 0); err = do_take_over_console(&mda_con, mda_first_vc-1, mda_last_vc-1, 0);
console_unlock();
return err;
} }
static void __exit mda_console_exit(void) static void __exit mda_console_exit(void)

View File

@ -297,7 +297,7 @@ static void newport_exit(void)
newport_set_def_font(i, NULL); newport_set_def_font(i, NULL);
} }
/* Can't be __init, take_over_console may call it later */ /* Can't be __init, do_take_over_console may call it later */
static const char *newport_startup(void) static const char *newport_startup(void)
{ {
int i; int i;
@ -746,6 +746,7 @@ static int newport_probe(struct gio_device *dev,
const struct gio_device_id *id) const struct gio_device_id *id)
{ {
unsigned long newport_addr; unsigned long newport_addr;
int err;
if (!dev->resource.start) if (!dev->resource.start)
return -EINVAL; return -EINVAL;
@ -759,8 +760,10 @@ static int newport_probe(struct gio_device *dev,
npregs = (struct newport_regs *)/* ioremap cannot fail */ npregs = (struct newport_regs *)/* ioremap cannot fail */
ioremap(newport_addr, sizeof(struct newport_regs)); ioremap(newport_addr, sizeof(struct newport_regs));
console_lock();
return take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1); err = do_take_over_console(&newport_con, 0, MAX_NR_CONSOLES - 1, 1);
console_unlock();
return err;
} }
static void newport_remove(struct gio_device *dev) static void newport_remove(struct gio_device *dev)

View File

@ -372,6 +372,7 @@ static const struct consw sti_con = {
static int __init sticonsole_init(void) static int __init sticonsole_init(void)
{ {
int err;
/* already initialized ? */ /* already initialized ? */
if (sticon_sti) if (sticon_sti)
return 0; return 0;
@ -382,7 +383,10 @@ static int __init sticonsole_init(void)
if (conswitchp == &dummy_con) { if (conswitchp == &dummy_con) {
printk(KERN_INFO "sticon: Initializing STI text console.\n"); printk(KERN_INFO "sticon: Initializing STI text console.\n");
return take_over_console(&sti_con, 0, MAX_NR_CONSOLES - 1, 1); console_lock();
err = do_take_over_console(&sti_con, 0, MAX_NR_CONSOLES - 1, 1);
console_unlock();
return err;
} }
return 0; return 0;
} }