Staging: w35und: plug memory leak in wbsoft_tx()
There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC memory as the contents are copied to ->TxBuffer in MdxTx() anyway before MLMESendFrame() returns. Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> Acked-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
3c01ec0d82
commit
16d3659fcd
|
@ -107,11 +107,8 @@ static void wbsoft_configure_filter(struct ieee80211_hw *dev,
|
||||||
|
|
||||||
static int wbsoft_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
|
static int wbsoft_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
|
||||||
{
|
{
|
||||||
char *buffer = kmalloc(skb->len, GFP_ATOMIC);
|
MLMESendFrame(my_adapter, skb->data, skb->len, FRAME_TYPE_802_11_MANAGEMENT);
|
||||||
printk("Sending frame %d bytes\n", skb->len);
|
|
||||||
memcpy(buffer, skb->data, skb->len);
|
|
||||||
if (1 == MLMESendFrame(my_adapter, buffer, skb->len, FRAME_TYPE_802_11_MANAGEMENT))
|
|
||||||
printk("frame sent ok (%d bytes)?\n", skb->len);
|
|
||||||
return NETDEV_TX_OK;
|
return NETDEV_TX_OK;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue