pinctrl: mediatek: mt7622: fix potential uninitialized value being returned
commit d6ed935513
("pinctrl: mediatek: add pinctrl driver for MT7622
SoC") leads to the following static checker warning:
drivers/pinctrl/mediatek/pinctrl-mt7622.c:1419 mtk_gpio_get()
error: uninitialized symbol 'value'.
1412 static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)
1413 {
1414 struct mtk_pinctrl *hw = dev_get_drvdata(chip->parent);
1415 int value;
1416
1417 mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
^^^^^^^^^^^^^^^^
1418
1419 return !!value;
1420 }
The appropriate error handling must be added to avoid the potential error
caused by uninitialized value being returned.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
fb36a7b07d
commit
181cdac02c
|
@ -1412,9 +1412,11 @@ static struct pinctrl_desc mtk_desc = {
|
|||
static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio)
|
||||
{
|
||||
struct mtk_pinctrl *hw = dev_get_drvdata(chip->parent);
|
||||
int value;
|
||||
int value, err;
|
||||
|
||||
mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
|
||||
err = mtk_hw_get_value(hw, gpio, PINCTRL_PIN_REG_DI, &value);
|
||||
if (err)
|
||||
return err;
|
||||
|
||||
return !!value;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue