redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ASoC: q6core: Use kmemdup to replace kzalloc + memcpy 

kmemdup has implemented the function that kzalloc() + memcpy() will
do. and we prefer to use the kmemdup rather than the open coded implementation.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
zhong jiang 2018-09-08 16:36:19 +08:00 committed by Mark Brown
parent fb77436a44
commit 18fbe800e6
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/soc/qcom/qdsp6/q6core.c
View File

@ -105,12 +105,10 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data)
bytes = sizeof(*fwk) + fwk->num_services *
sizeof(fwk->svc_api_info[0]);
core->fwk_version = kzalloc(bytes, GFP_ATOMIC);
core->fwk_version = kmemdup(data->payload, bytes, GFP_ATOMIC);
if (!core->fwk_version)
return -ENOMEM;
memcpy(core->fwk_version, data->payload, bytes);
core->fwk_version_supported = true;
core->resp_received = true;
@ -124,12 +122,10 @@ static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *data)
len = sizeof(*v) + v->num_services * sizeof(v->svc_api_info[0]);
core->svc_version = kzalloc(len, GFP_ATOMIC);
core->svc_version = kmemdup(data->payload, len, GFP_ATOMIC);
if (!core->svc_version)
return -ENOMEM;
memcpy(core->svc_version, data->payload, len);
core->get_version_supported = true;
core->resp_received = true;