redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: panel: Remove more magic number comparison 

Use a defined value instead of magic number comparison
for checking whether a module param value has been set.

Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hifive-unleashed-5.1
Mariusz Gorski 2014-11-27 22:36:52 +01:00 committed by Greg Kroah-Hartman
parent 8037e2a3c0
commit 1a4b2e3e6c
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/staging/panel/panel.c
View File

@ -1494,17 +1494,17 @@ static void lcd_init(void)
}
/* Overwrite with module params set on loading */
if (lcd_height > -1)
if (lcd_height != NOT_SET)
lcd.height = lcd_height;
if (lcd_width > -1)
if (lcd_width != NOT_SET)
lcd.width = lcd_width;
if (lcd_bwidth > -1)
if (lcd_bwidth != NOT_SET)
lcd.bwidth = lcd_bwidth;
if (lcd_hwidth > -1)
if (lcd_hwidth != NOT_SET)
lcd.hwidth = lcd_hwidth;
if (lcd_charset > -1)
if (lcd_charset != NOT_SET)
lcd.charset = lcd_charset;
if (lcd_proto > -1)
if (lcd_proto != NOT_SET)
lcd.proto = lcd_proto;
if (lcd_e_pin != PIN_NOT_SET)
lcd.pins.e = lcd_e_pin;
@ -2304,16 +2304,16 @@ static int __init panel_init_module(void)
* Overwrite selection with module param values (both keypad and lcd),
* where the deprecated params have lower prio.
*/
if (keypad_enabled > -1)
if (keypad_enabled != NOT_SET)
selected_keypad_type = keypad_enabled;
if (keypad_type > -1)
if (keypad_type != NOT_SET)
selected_keypad_type = keypad_type;
keypad.enabled = (selected_keypad_type > 0);
if (lcd_enabled > -1)
if (lcd_enabled != NOT_SET)
selected_lcd_type = lcd_enabled;
if (lcd_type > -1)
if (lcd_type != NOT_SET)
selected_lcd_type = lcd_type;
lcd.enabled = (selected_lcd_type > 0);