redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

drivers:iio:accel:mma8452: added cleanup provision in case of failure. 

mma8452_set_freefall_mode can return -ve value in case if
i2c_smbus_read_byte_data fails. This function is called from mma8452_probe,
and returning -ve value from probe indicates probe failure. Need to call
iio_triggered_buffer_cleanup & iio_trigger_cleanup in this case.

Signed-off-by: Bijosh Thykkoottathil <bijosh.t@hotmail.com>
Acked-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
hifive-unleashed-5.1
Bijosh Thykkoottathil 2016-07-04 10:08:53 +00:00 committed by Jonathan Cameron
parent 21d41655f5
commit 1a965d405f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/iio/accel/mma8452.c
View File

@ -1579,8 +1579,8 @@ static int mma8452_probe(struct i2c_client *client,
goto buffer_cleanup;
ret = mma8452_set_freefall_mode(data, false);
if (ret)
return ret;
if (ret < 0)
goto buffer_cleanup;
return 0;