redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

hwmon: (lm85) Simplify RANGE_TO_REG 

Function RANGE_TO_REG can easily be simplified. Credits go to Herbert
Poetzl for indirectly suggesting this to me. I tested that the new
implementation returns the same result as the original implementation
for all input values.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Herbert Poetzl <herbert@13thfloor.at>
hifive-unleashed-5.1
Jean Delvare 2008-10-17 17:51:14 +02:00 committed by Jean Delvare
parent 67712d0192
commit 1b92adaddd
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/hwmon/lm85.c
View File

@ -174,20 +174,13 @@ static int RANGE_TO_REG(int range)
{
int i;
if (range >= lm85_range_map[15])
return 15;
/* Find the closest match */
for (i = 14; i >= 0; --i) {
if (range >= lm85_range_map[i]) {
if ((lm85_range_map[i + 1] - range) <
(range - lm85_range_map[i]))
return i + 1;
return i;
}
for (i = 0; i < 15; ++i) {
if (range <= (lm85_range_map[i] + lm85_range_map[i + 1]) / 2)
break;
}
return 0;
return i;
}
#define RANGE_FROM_REG(val) lm85_range_map[(val) & 0x0f]