redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[XFS] fix valid but harmless sparse warning 

The new xlog_recover_do_reg_buffer checks call be16_to_cpu on di_gen which
is a 32bit value so sparse rightly complains. Fortunately the warning is
harmless because we don't care for the value, but only whether it's
non-NULL. Due to that fact we can simply kill the endian swaps on this and
the previous di_mode check entirely.

SGI-PV: 969656
SGI-Modid: xfs-linux-melb:xfs-kern:29709a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Signed-off-by: Tim Shimmin <tes@sgi.com>
hifive-unleashed-5.1
Christoph Hellwig 2007-09-19 15:27:30 +10:00 committed by Tim Shimmin
parent bcc7b445ef
commit 1bc5858d0d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/xfs/xfs_log_recover.c
View File

@ -1920,9 +1920,9 @@ xlog_recover_do_reg_buffer(
stale_buf = 1;
break;
}
if (be16_to_cpu(dip->di_core.di_mode))
if (dip->di_core.di_mode)
mode_count++;
if (be16_to_cpu(dip->di_core.di_gen))
if (dip->di_core.di_gen)
gen_count++;
}