redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

afs: proc cells and rootcell are writeable 

Both proc files are writeable and used for configuring cells. But
there is missing correct mode flag for writeable files. Without
this patch both proc files are read only.

[ It turns out they aren't really read-only, since root can write to
  them even if the write bit isn't set due to CAP_DAC_OVERRIDE ]

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
hifive-unleashed-5.1
Pali Rohár 2014-01-28 20:26:44 +00:00 committed by Linus Torvalds
parent 5a5e75f471
commit 1bda2ac071
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/afs/proc.c
View File

@ -130,8 +130,8 @@ int afs_proc_init(void)
if (!proc_afs)
goto error_dir;
if (!proc_create("cells", 0, proc_afs, &afs_proc_cells_fops) ||
!proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops))
if (!proc_create("cells", 0644, proc_afs, &afs_proc_cells_fops) ||
!proc_create("rootcell", 0644, proc_afs, &afs_proc_rootcell_fops))
goto error_tree;
_leave(" = 0");