redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: gasket: ioctl common: convert various logs to debug level

Browse source 
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Todd Poynor 2018-07-21 06:35:04 -07:00 committed by Greg Kroah-Hartman
parent 040c626008
commit 1d079f20d5
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/gasket/gasket_core.c
View file

@ -1801,7 +1801,7 @@ static long gasket_ioctl(struct file *filp, uint cmd, ulong arg)
if (driver_desc->ioctl_handler_cb) if (driver_desc->ioctl_handler_cb)
return driver_desc->ioctl_handler_cb(filp, cmd, argp); return driver_desc->ioctl_handler_cb(filp, cmd, argp);
gasket_log_error( gasket_log_debug(
gasket_dev, "Received unknown ioctl 0x%x", cmd); gasket_dev, "Received unknown ioctl 0x%x", cmd);
return -EINVAL; return -EINVAL;
} }

6
drivers/staging/gasket/gasket_ioctl.c
View file

@ -73,7 +73,7 @@ long gasket_handle_ioctl(struct file *filp, uint cmd, void __user *argp)
} }
} else if (!gasket_ioctl_check_permissions(filp, cmd)) { } else if (!gasket_ioctl_check_permissions(filp, cmd)) {
trace_gasket_ioctl_exit(-EPERM); trace_gasket_ioctl_exit(-EPERM);
gasket_log_error(gasket_dev, "ioctl cmd=%x noperm.", cmd); gasket_log_debug(gasket_dev, "ioctl cmd=%x noperm.", cmd);
return -EPERM; return -EPERM;
} }
@ -132,7 +132,7 @@ long gasket_handle_ioctl(struct file *filp, uint cmd, void __user *argp)
* the arg. * the arg.
*/ */
trace_gasket_ioctl_integer_data(arg); trace_gasket_ioctl_integer_data(arg);
gasket_log_warn( gasket_log_debug(
gasket_dev, gasket_dev,
"Unknown ioctl cmd=0x%x not caught by " "Unknown ioctl cmd=0x%x not caught by "
"gasket_is_supported_ioctl", "gasket_is_supported_ioctl",
@ -329,7 +329,7 @@ static int gasket_partition_page_table(
gasket_dev->page_table[ibuf.page_table_index]); gasket_dev->page_table[ibuf.page_table_index]);
if (ibuf.size > max_page_table_size) { if (ibuf.size > max_page_table_size) {
gasket_log_error( gasket_log_debug(
gasket_dev, gasket_dev,
"Partition request 0x%llx too large, max is 0x%x.", "Partition request 0x%llx too large, max is 0x%x.",
ibuf.size, max_page_table_size); ibuf.size, max_page_table_size);