redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

net: stmmac: fix a broken u32 less than zero check 

The check that queue is less or equal to zero is always true
because queue is a u32; queue is decremented and will wrap around
and never go -ve. Fix this by making queue an int.

Detected by CoverityScan, CID#1428988 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
hifive-unleashed-5.1
Colin Ian King 2017-06-06 14:10:49 +01:00 committed by David S. Miller
parent 426849e661
commit 1d3028f4c1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
View File

@ -1208,7 +1208,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags)
u32 rx_count = priv->plat->rx_queues_to_use;
unsigned int bfsize = 0;
int ret = -ENOMEM;
u32 queue;
int queue;
int i;
if (priv->hw->mode->set_16kib_bfsize)