redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

cfq-iosched: Get rid of unnecessary local variable 

Use of local varibale "n" seems to be unnecessary. Remove it. This brings
it inline with function __cfq_group_st_add(), which is also doing the
similar operation of adding a group to a rb tree.

No functionality change here.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
hifive-unleashed-5.1
Vivek Goyal 2012-10-03 16:57:00 -04:00 committed by Tejun Heo
parent 6d816ec7c8
commit 1f23f12151
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
block/cfq-iosched.c
View File

@ -1658,8 +1658,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
cfqq->service_tree = st;
p = &st->rb.rb_node;
while (*p) {
struct rb_node **n;
parent = *p;
__cfqq = rb_entry(parent, struct cfq_queue, rb_node);
@ -1667,13 +1665,11 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
* sort by key, that represents service time.
*/
if (time_before(rb_key, __cfqq->rb_key))
n = &(*p)->rb_left;
p = &parent->rb_left;
else {
n = &(*p)->rb_right;
p = &parent->rb_right;
left = 0;
}
p = n;
}
if (left)