USB: fix mistake in usb_hcd_giveback_urb
This patch (as971) fixes a small mistake: The URB's completion status needs to be adjusted before the URB is passed to usmon_urb_complete(), not afterward. Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
ed6e52829c
commit
1f5a3d0f34
|
@ -1266,9 +1266,6 @@ int usb_hcd_unlink_urb (struct urb *urb, int status)
|
|||
*/
|
||||
void usb_hcd_giveback_urb (struct usb_hcd *hcd, struct urb *urb)
|
||||
{
|
||||
unmap_urb_for_dma(hcd, urb);
|
||||
usbmon_urb_complete (&hcd->self, urb);
|
||||
usb_unanchor_urb(urb);
|
||||
urb->hcpriv = NULL;
|
||||
if (unlikely(urb->unlinked))
|
||||
urb->status = urb->unlinked;
|
||||
|
@ -1277,6 +1274,10 @@ void usb_hcd_giveback_urb (struct usb_hcd *hcd, struct urb *urb)
|
|||
!urb->status))
|
||||
urb->status = -EREMOTEIO;
|
||||
|
||||
unmap_urb_for_dma(hcd, urb);
|
||||
usbmon_urb_complete(&hcd->self, urb);
|
||||
usb_unanchor_urb(urb);
|
||||
|
||||
/* pass ownership to the completion handler */
|
||||
urb->complete (urb);
|
||||
atomic_dec (&urb->use_count);
|
||||
|
|
Loading…
Reference in a new issue