redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

spi: dw: fix crash on setup stage 

The commit 1a7b7ee72c (spi: Ensure that CS line is in non-active state after
spi_setup()) introduces an unconditional call of spi_set_cs() before ->setup().
The dw_spi_set_cs() relies on that fact that ->setup() is already called, but
it doesn't now. This patch fixes the crash by adding an additional check to
dw_spi_set_cs().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Andy Shevchenko 2015-03-25 20:26:26 +02:00 committed by Mark Brown
parent 36111da783
commit 207cda93f0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/spi/spi-dw.c
View File

@ -144,7 +144,7 @@ static void dw_spi_set_cs(struct spi_device *spi, bool enable)
struct chip_data *chip = spi_get_ctldata(spi);
/* Chip select logic is inverted from spi_set_cs() */
if (chip->cs_control)
if (chip && chip->cs_control)
chip->cs_control(!enable);
if (!enable)