redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

block: clarify badblocks lifetime 

The badblocks list attached to a gendisk is allocated by the driver
which equates to the driver owning the lifetime of the object.  Do not
automatically free it in del_gendisk(). This is in preparation for
expanding the use of badblocks in libnvdimm drivers and introducing
devm_init_badblocks().

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
hifive-unleashed-5.1
Dan Williams 2016-01-06 12:03:41 -08:00
parent d3b407fb3f
commit 20a308f09e
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
block/badblocks.c
View File

@ -555,6 +555,8 @@ EXPORT_SYMBOL_GPL(badblocks_init);
*/
void badblocks_exit(struct badblocks *bb)
{
if (!bb)
return;
kfree(bb->page);
bb->page = NULL;
}

5
block/genhd.c
View File

@ -670,11 +670,6 @@ void del_gendisk(struct gendisk *disk)
blk_unregister_queue(disk);
blk_unregister_region(disk_devt(disk), disk->minors);
if (disk->bb) {
badblocks_exit(disk->bb);
kfree(disk->bb);
}
part_stat_set_all(&disk->part0, 0);
disk->part0.stamp = 0;