redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

[PATCH] bcm43xx: MANUALWLAN fixes 

During testing of bcm43xx interference mitigation, two problems were
discovered:

(1) When the MANUALWLAN mode was set, routines _stack_save and _stack_restore
    generated assertions that were traced to saving ILT registers with addresses
    > 0xFFF. This problem was fixed by adding one bit to the field used for
    the offset, and subtracting one bit from the space used for the id.
(2) In MANUALWLAN mode, the IRQ XMIT errors are generated. The cause of these
    errors has not yet been located. Any suggestions on debugging this problem
    would be greatly appreciated.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
hifive-unleashed-5.1
Larry Finger 2007-03-14 10:32:07 -05:00 committed by John W. Linville
parent db98e0b434
commit 21665a69e6
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/net/wireless/bcm43xx/bcm43xx_radio.c
View File

@ -882,10 +882,10 @@ static void _stack_save(u32 *_stackptr, size_t *stackidx,
{
u32 *stackptr = &(_stackptr[*stackidx]);
assert((offset & 0xF000) == 0x0000);
assert((id & 0xF0) == 0x00);
assert((offset & 0xE000) == 0x0000);
assert((id & 0xF8) == 0x00);
*stackptr = offset;
*stackptr |= ((u32)id) << 12;
*stackptr |= ((u32)id) << 13;
*stackptr |= ((u32)value) << 16;
(*stackidx)++;
assert(*stackidx < BCM43xx_INTERFSTACK_SIZE);
@ -896,12 +896,12 @@ static u16 _stack_restore(u32 *stackptr,
{
size_t i;
assert((offset & 0xF000) == 0x0000);
assert((id & 0xF0) == 0x00);
assert((offset & 0xE000) == 0x0000);
assert((id & 0xF8) == 0x00);
for (i = 0; i < BCM43xx_INTERFSTACK_SIZE; i++, stackptr++) {
if ((*stackptr & 0x00000FFF) != offset)
if ((*stackptr & 0x00001FFF) != offset)
continue;
if (((*stackptr & 0x0000F000) >> 12) != id)
if (((*stackptr & 0x00007000) >> 13) != id)
continue;
return ((*stackptr & 0xFFFF0000) >> 16);
}