1
0
Fork 0

net/packet: Improve the comment about LL header visibility criteria

The "dev_has_header" function, recently added in
commit d549699048 ("net/packet: fix packet receive on L3 devices
without visible hard header"),
is more accurate as criteria for determining whether a device exposes
the LL header to upper layers, because in addition to dev->header_ops,
it also checks for dev->header_ops->create.

When transmitting an skb on a device, dev_hard_header can be called to
generate an LL header. dev_hard_header will only generate a header if
dev->header_ops->create is present.

Signed-off-by: Xie He <xie.he.0141@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20210205224124.21345-1-xie.he.0141@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
master
Xie He 2021-02-05 14:41:24 -08:00 committed by Jakub Kicinski
parent 163a180213
commit 21c85974aa
1 changed files with 2 additions and 2 deletions

View File

@ -135,11 +135,11 @@ Resume
On transmit:
------------
dev->header_ops != NULL
dev_has_header(dev) == true
mac_header -> ll header
data -> ll header
dev->header_ops == NULL (ll header is invisible to us)
dev_has_header(dev) == false (ll header is invisible to us)
mac_header -> data
data -> data