redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

leds: ledtrig-transient: fix duration to be msec instead of jiffies 

The transient trigger duration is documented to be in msec units, but is
actually in jiffies units. Other time based triggers are in msec units
as well. Fix the timer setup to convert from msec.

This could break an existing userspace that worked around this problem,
but exposing jiffies to userspace is just wrong and would break anyway
if HZ is changed.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Shuah Khan <shuahkhan@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
hifive-unleashed-5.1
Rob Herring 2015-11-10 17:10:17 -06:00 committed by Jacek Anaszewski
parent df8ff5d2e0
commit 22f933add4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/leds/trigger/ledtrig-transient.c
View File

@ -85,7 +85,7 @@ static ssize_t transient_activate_store(struct device *dev,
transient_data->restore_state =
(transient_data->state == LED_FULL) ? LED_OFF : LED_FULL;
mod_timer(&transient_data->timer,
jiffies + transient_data->duration);
jiffies + msecs_to_jiffies(transient_data->duration));
}
/* state == 0 && transient_data->activate == 0