redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

staging: comedi: adv_pci1723: remove private data 'da_range'

Browse source 
This member of the private data is initialized to 0 by pci1723_reset()
and is not used any where else in the driver. Remove it.

Use the register map defines to set the range for each output channel.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2014-11-21 14:22:28 -07:00 committed by Greg Kroah-Hartman
parent 01601aaf9f
commit 24001039a4
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/comedi/drivers/adv_pci1723.c
View file

@ -86,7 +86,6 @@ TODO:
#define PCI1723_VREF_POS10V (3 << 0)
struct pci1723_private {
unsigned char da_range[8]; /* D/A output range for each channel */
unsigned short ao_data[8]; /* data output buffer */
};
@ -105,8 +104,7 @@ static int pci1723_reset(struct comedi_device *dev)
devpriv->ao_data[i] = 0x8000;
outw(devpriv->ao_data[i], dev->iobase + PCI1723_AO_REG(i));
/* set all ranges to +/- 10V */
devpriv->da_range[i] = 0;
outw(((devpriv->da_range[i] << 4) | i),
outw(PCI1723_CTRL_RANGE(0) | PCI1723_CTRL_CHAN(i),
PCI1723_CTRL_REG);
}