redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

metronomefb: don't free firmware twice in error path 

Right now, if request_irq or anthing after it fails than we free the firmware
for the second time what might end bad :)

Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
Acked-by: Jaya Kumar <jayakumar.lkml@gmail.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
hifive-unleashed-5.1
Sebastian Siewior 2008-04-28 02:15:39 -07:00 committed by Linus Torvalds
parent 03c33a4f00
commit 2422fbba06
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/video/metronomefb.c
View File

@ -671,14 +671,14 @@ static int __devinit metronomefb_probe(struct platform_device *dev)
retval = load_waveform((u8 *) fw_entry->data, fw_entry->size,
par->metromem_wfm, 3, 31, &par->frame_count);
release_firmware(fw_entry);
if (retval < 0) {
printk(KERN_ERR "metronomefb: couldn't process waveform\n");
goto err_ld_wfm;
goto err_dma_free;
}
release_firmware(fw_entry);
if (board->setup_irq(info))
goto err_ld_wfm;
goto err_dma_free;
retval = metronome_init_regs(par);
if (retval < 0)
@ -719,8 +719,6 @@ err_fb_rel:
framebuffer_release(info);
err_free_irq:
board->free_irq(info);
err_ld_wfm:
release_firmware(fw_entry);
err_dma_free:
dma_free_writecombine(&dev->dev, par->metromemsize, par->metromem,
par->metromem_dma);