redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

selftests/timers: Quiet warning due to lack of return check on brk 

The posix_timers.c test has a loop that tries to keep it in
kernel space, repeatedly calling brk(). However, it doesn't
check the return value, which causes warnings.

This patch adds a err value which captures the return value
and modifies the test so it will quit if a failure occurs.

Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Tested-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
hifive-unleashed-5.1
John Stultz 2015-03-11 17:39:58 -07:00 committed by Shuah Khan
parent 03438212d0
commit 2430ec652d
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/testing/selftests/timers/posix_timers.c
View File

@ -35,10 +35,11 @@ static void user_loop(void)
static void kernel_loop(void)
{
void *addr = sbrk(0);
int err = 0;
while (!done) {
brk(addr + 4096);
brk(addr);
while (!done && !err) {
err = brk(addr + 4096);
err |= brk(addr);
}
}
@ -190,8 +191,6 @@ static int check_timer_create(int which)
int main(int argc, char **argv)
{
int err;
printf("Testing posix timers. False negative may happen on CPU execution \n");
printf("based timers if other threads run on the CPU...\n");