ALSA: line6: Sync the pending work cancel at disconnection
commit 68359a1ad8
upstream.
Recently syzkaller reported a UAF in LINE6 driver, and it's likely
because we call cancel_delayed_work() at the disconnect callback
instead of cancel_delayed_work_sync(). Let's use the correct one
instead.
Reported-by: syzbot+145012a46658ac00fc9e@syzkaller.appspotmail.com
Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/s5hlfjr4gio.wl-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
5.4-rM2-2.2.x-imx-squashed
parent
91a6d4049c
commit
25fd7ee3ba
|
@ -820,7 +820,7 @@ void line6_disconnect(struct usb_interface *interface)
|
|||
if (WARN_ON(usbdev != line6->usbdev))
|
||||
return;
|
||||
|
||||
cancel_delayed_work(&line6->startup_work);
|
||||
cancel_delayed_work_sync(&line6->startup_work);
|
||||
|
||||
if (line6->urb_listen != NULL)
|
||||
line6_stop_listen(line6);
|
||||
|
|
Loading…
Reference in New Issue