redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

iio: amplifiers: ad8366: move channel init before iio_device_register() 

Otherwise a race condition can occur, where userspace can start operations
before the channels have been properly initialized.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
hifive-unleashed-5.1
Alexandru Ardelean 2018-05-21 09:40:05 +03:00 committed by Jonathan Cameron
parent 55dda0abcf
commit 2636d00575
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/iio/amplifiers/ad8366.c
View File

@ -161,12 +161,14 @@ static int ad8366_probe(struct spi_device *spi)
indio_dev->channels = ad8366_channels;
indio_dev->num_channels = ARRAY_SIZE(ad8366_channels);
ret = ad8366_write(indio_dev, 0 , 0);
if (ret < 0)
goto error_disable_reg;
ret = iio_device_register(indio_dev);
if (ret)
goto error_disable_reg;
ad8366_write(indio_dev, 0, 0);
return 0;
error_disable_reg: