redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

net: qca_spi: Fix possible race during probe

Browse source 
Registering the netdev before setting the priv data is unsafe.
So fix this possible race by setting the priv data first.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Cc: <stable@vger.kernel.org> # v3.18+
Fixes: 291ab06e (net: qualcomm: new Ethernet over SPI driver for QCA7000)
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Stefan Wahren 2015-05-09 07:58:09 +00:00 committed by David S. Miller
parent 7c0c826828
commit 268be0f7a7
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/ethernet/qualcomm/qca_spi.c
View file

@ -912,6 +912,8 @@ qca_spi_probe(struct spi_device *spi_device)
qca->spi_dev = spi_device; qca->spi_dev = spi_device;
qca->legacy_mode = legacy_mode; qca->legacy_mode = legacy_mode;
spi_set_drvdata(spi_device, qcaspi_devs);
mac = of_get_mac_address(spi_device->dev.of_node); mac = of_get_mac_address(spi_device->dev.of_node);
if (mac) if (mac)
@ -944,8 +946,6 @@ qca_spi_probe(struct spi_device *spi_device)
return -EFAULT; return -EFAULT;
} }
spi_set_drvdata(spi_device, qcaspi_devs);
qcaspi_init_device_debugfs(qca); qcaspi_init_device_debugfs(qca);
return 0; return 0;