redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

dma: mmp_pdma: clear DRCMR when free a phy channel 

In mmp pdma, phy channels are allocated/freed dynamically.
The mapping from DMA request to DMA channel number in DRCMR
should be cleared when a phy channel is freed. Otherwise
conflicts will happen when:
1. A is using channel 2 and free it after finished, but A
still maps to channel 2 in DRCMR of A.
2. Now another one B gets channel 2. So B maps to channel 2
too in DRCMR of B.
In the datasheet, it is described that "Do not map two active
requests to the same channel since it produces unpredictable
results" and we can observe that during test.

Signed-off-by: Xiang Wang <wangx@marvell.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
hifive-unleashed-5.1
Xiang Wang 2013-06-18 14:55:59 +08:00 committed by Vinod Koul
parent 027f28b7bb
commit 26a2dfdeb9
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/mmp_pdma.c
View File

@ -252,10 +252,16 @@ static void mmp_pdma_free_phy(struct mmp_pdma_chan *pchan)
{
struct mmp_pdma_device *pdev = to_mmp_pdma_dev(pchan->chan.device);
unsigned long flags;
u32 reg;
if (!pchan->phy)
return;
/* clear the channel mapping in DRCMR */
reg = pchan->phy->vchan->drcmr;
reg = ((reg < 64) ? 0x0100 : 0x1100) + ((reg & 0x3f) << 2);
writel(0, pchan->phy->base + reg);
spin_lock_irqsave(&pdev->phy_lock, flags);
pchan->phy->vchan = NULL;
pchan->phy = NULL;