net: mvneta: Use devm_kmalloc_array() in mvneta_init()
* A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net>hifive-unleashed-5.1
parent
5f8ddeab10
commit
2911063011
|
@ -4027,9 +4027,11 @@ static int mvneta_init(struct device *dev, struct mvneta_port *pp)
|
||||||
rxq->size = pp->rx_ring_size;
|
rxq->size = pp->rx_ring_size;
|
||||||
rxq->pkts_coal = MVNETA_RX_COAL_PKTS;
|
rxq->pkts_coal = MVNETA_RX_COAL_PKTS;
|
||||||
rxq->time_coal = MVNETA_RX_COAL_USEC;
|
rxq->time_coal = MVNETA_RX_COAL_USEC;
|
||||||
rxq->buf_virt_addr = devm_kmalloc(pp->dev->dev.parent,
|
rxq->buf_virt_addr
|
||||||
rxq->size * sizeof(void *),
|
= devm_kmalloc_array(pp->dev->dev.parent,
|
||||||
GFP_KERNEL);
|
rxq->size,
|
||||||
|
sizeof(*rxq->buf_virt_addr),
|
||||||
|
GFP_KERNEL);
|
||||||
if (!rxq->buf_virt_addr)
|
if (!rxq->buf_virt_addr)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue