redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

tools/testing/scatterlist: Show errors in human readable form

Browse source 
Instead of just asserting dump some more useful info about what the test
saw versus what it expected to see.

Link: https://lore.kernel.org/r/20201004154340.1080481-4-leon@kernel.org
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Maor Gottlieb <maorg@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Tvrtko Ursulin 2020-10-04 18:43:39 +03:00 committed by Jason Gunthorpe
parent efc5b2e73c
commit 29d88681fb
1 changed files with 34 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
tools/testing/scatterlist/main.c
View file

@ -5,6 +5,15 @@
#define MAX_PAGES (64)
struct test {
int alloc_ret;
unsigned num_pages;
unsigned *pfn;
unsigned size;
unsigned int max_seg;
unsigned int expected_segments;
};
static void set_pages(struct page **pages, const unsigned *array, unsigned num)
{
unsigned int i;
@ -17,17 +26,32 @@ static void set_pages(struct page **pages, const unsigned *array, unsigned num)
#define pfn(...) (unsigned []){ __VA_ARGS__ }
static void fail(struct test *test, struct sg_table *st, const char *cond)
{
unsigned int i;
fprintf(stderr, "Failed on '%s'!\n\n", cond);
printf("size = %u, max segment = %u, expected nents = %u\nst->nents = %u, st->orig_nents= %u\n",
test->size, test->max_seg, test->expected_segments, st->nents,
st->orig_nents);
printf("%u input PFNs:", test->num_pages);
for (i = 0; i < test->num_pages; i++)
printf(" %x", test->pfn[i]);
printf("\n");
exit(1);
}
#define VALIDATE(cond, st, test) \
if (!(cond)) \
fail((test), (st), #cond);
int main(void)
{
const unsigned int sgmax = SCATTERLIST_MAX_SEGMENT;
struct test {
int alloc_ret;
unsigned num_pages;
unsigned *pfn;
unsigned size;
unsigned int max_seg;
unsigned int expected_segments;
} *test, tests[] = {
struct test *test, tests[] = {
{ -EINVAL, 1, pfn(0), PAGE_SIZE, PAGE_SIZE + 1, 1 },
{ -EINVAL, 1, pfn(0), PAGE_SIZE, 0, 1 },
{ -EINVAL, 1, pfn(0), PAGE_SIZE, sgmax + 1, 1 },
@ -67,8 +91,8 @@ int main(void)
if (test->alloc_ret)
continue;
assert(st.nents == test->expected_segments);
assert(st.orig_nents == test->expected_segments);
VALIDATE(st.nents == test->expected_segments, &st, test);
VALIDATE(st.orig_nents == test->expected_segments, &st, test);
sg_free_table(&st);
}