redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

crypto: skcipher - remove unnecessary setting of walk->nbytes 

Setting 'walk->nbytes = walk->total' in skcipher_walk_first() doesn't
make sense because actually walk->nbytes needs to be set to the length
of the first step in the walk, which may be less than walk->total.  This
is done by skcipher_walk_next() which is called immediately afterwards.
Also walk->nbytes was already set to 0 in skcipher_walk_skcipher(),
which is a better default value in case it's forgotten to be set later.

Therefore, remove the unnecessary assignment to walk->nbytes.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
hifive-unleashed-5.1
Eric Biggers 2018-07-23 10:21:29 -07:00 committed by Herbert Xu
parent 3dd8cc00c3
commit 2a57c0be22
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crypto/skcipher.c
View File

@ -436,7 +436,6 @@ static int skcipher_walk_first(struct skcipher_walk *walk)
}
walk->page = NULL;
walk->nbytes = walk->total;
return skcipher_walk_next(walk);
}