redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ata: ahci_xgene: potential NULL dereference in probe 

Smatch complains about this potential NULL dereference of "acpi_id".

Fixes: c9802a4be6 ('ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
hifive-unleashed-5.1
Dan Carpenter 2015-05-15 12:24:15 +03:00 committed by Tejun Heo
parent c9802a4be6
commit 2d32d10103
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ata/ahci_xgene.c
View File

@ -732,9 +732,7 @@ static int xgene_ahci_probe(struct platform_device *pdev)
if (!acpi_id) {
dev_warn(&pdev->dev, "No node entry in ACPI table. Assume version1\n");
version = XGENE_AHCI_V1;
}
if (acpi_id->driver_data) {
} else if (acpi_id->driver_data) {
version = (enum xgene_ahci_version) acpi_id->driver_data;
status = acpi_get_object_info(ACPI_HANDLE(&pdev->dev), &info);
if (ACPI_FAILURE(status)) {