redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

char: tpm: Deletion of unnecessary checks before the function call "tpm_dev_vendor_release" 

The tpm_dev_vendor_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
hifive-unleashed-5.1
Markus Elfring 2014-11-19 14:44:15 +01:00 committed by Peter Huewe
parent 9fd8e5a25e
commit 2dfc2deda2
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/char/tpm/tpm_i2c_atmel.c
View File

@ -206,8 +206,7 @@ static int i2c_atmel_remove(struct i2c_client *client)
struct device *dev = &(client->dev);
struct tpm_chip *chip = dev_get_drvdata(dev);
if (chip)
tpm_dev_vendor_release(chip);
tpm_dev_vendor_release(chip);
tpm_remove_hardware(dev);
kfree(chip);
return 0;

3
drivers/char/tpm/tpm_i2c_nuvoton.c
View File

@ -630,8 +630,7 @@ static int i2c_nuvoton_remove(struct i2c_client *client)
struct device *dev = &(client->dev);
struct tpm_chip *chip = dev_get_drvdata(dev);
if (chip)
tpm_dev_vendor_release(chip);
tpm_dev_vendor_release(chip);
tpm_remove_hardware(dev);
kfree(chip);
return 0;