redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

cpumask: convert drivers/net/sfc 

Impact: reduce stack usage, use new cpumask API.

Remove a cpumask from the stack.  Ben Hutchings indicated that printing
a warning and returning 1 was acceptable for the corner case where allocation
fails.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Mike Travis <travis@sgi.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Cc: linux-net-drivers@solarflare.com
hifive-unleashed-5.1
Rusty Russell 2009-01-10 21:58:09 -08:00 committed by Ingo Molnar
parent f7df8ed164
commit 2f8975fbcf
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/net/sfc/efx.c
View File

@ -854,20 +854,27 @@ static void efx_fini_io(struct efx_nic *efx)
* interrupts across them. */
static int efx_wanted_rx_queues(void)
{
cpumask_t core_mask;
cpumask_var_t core_mask;
int count;
int cpu;
cpus_clear(core_mask);
if (!alloc_cpumask_var(&core_mask, GFP_KERNEL)) {
printk(KERN_WARNING
"efx.c: allocation failure, irq balancing hobbled\n");
return 1;
}
cpumask_clear(core_mask);
count = 0;
for_each_online_cpu(cpu) {
if (!cpu_isset(cpu, core_mask)) {
if (!cpumask_test_cpu(cpu, core_mask)) {
++count;
cpumask_or(&core_mask, &core_mask,
cpumask_or(core_mask, core_mask,
topology_core_cpumask(cpu));
}
}
free_cpumask_var(core_mask);
return count;
}