From 2ffabf50bd0038acc0e92fe78915610a7fded182 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Wed, 23 Aug 2017 15:34:33 +0100 Subject: [PATCH] staging: r8822be: fix memory leak of eeprom_map on error exit return A memory leak of eeprom_map occurs if the call to halmac_eeprom_parser_88xx fails. Fix this by kfree'ing it before returning. Detected by CoverityScan, CID#1454569 ("Resource leak") Fixes: 938a0447f094 ("staging: r8822be: Add code for halmac sub-driver") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c b/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c index 0551c471ac43..f623ae55d1a1 100644 --- a/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c +++ b/drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_api_88xx.c @@ -1950,8 +1950,10 @@ halmac_dump_logical_efuse_map_88xx(struct halmac_adapter *halmac_adapter, if (halmac_eeprom_parser_88xx(halmac_adapter, halmac_adapter->hal_efuse_map, - eeprom_map) != HALMAC_RET_SUCCESS) + eeprom_map) != HALMAC_RET_SUCCESS) { + kfree(eeprom_map); return HALMAC_RET_EEPROM_PARSING_FAIL; + } PLATFORM_EVENT_INDICATION( driver_adapter, HALMAC_FEATURE_DUMP_LOGICAL_EFUSE,