redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

perf machine: Null-terminate version char array upon fgets(/proc/version) error 

If fgets() fails due to any other error besides end-of-file, the version
char array may not even be null-terminated.

Signed-off-by: Donald Yandt <donald.yandt@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Avi Kivity <avi@scylladb.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Yanmin Zhang <yanmin_zhang@linux.intel.com>
Fixes: a1645ce12a ("perf: 'perf kvm' tool for monitoring guest performance from host")
Link: http://lkml.kernel.org/r/20190514110100.22019-1-donald.yandt@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
hifive-unleashed-5.2
Donald Yandt 2019-05-14 07:01:00 -04:00 committed by Arnaldo Carvalho de Melo
parent bf6d18cffa
commit 30ba5b0e66
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/perf/util/machine.c
View File

@ -1234,8 +1234,9 @@ static char *get_kernel_version(const char *root_dir)
if (!file)
return NULL;
version[0] = '\0';
tmp = fgets(version, sizeof(version), file);
if (!tmp)
*version = '\0';
fclose(file);
name = strstr(version, prefix);