redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

net: depca: Omit check for multicast bit in netdev_for_each_mc_addr

Browse source 
There is no need to check for the address being a multicast address in
the netdev_for_each_mc_addr loop, so remove it.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Tobias Klauser 2011-06-29 02:15:15 +00:00 committed by David S. Miller
parent bda7ed4793
commit 3170ff54c2
1 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
drivers/net/depca.c
View file

@ -1270,7 +1270,6 @@ static void SetMulticastFilter(struct net_device *dev)
{ {
struct depca_private *lp = netdev_priv(dev); struct depca_private *lp = netdev_priv(dev);
struct netdev_hw_addr *ha; struct netdev_hw_addr *ha;
char *addrs;
int i, j, bit, byte; int i, j, bit, byte;
u16 hashcode; u16 hashcode;
u32 crc; u32 crc;
@ -1285,19 +1284,15 @@ static void SetMulticastFilter(struct net_device *dev)
} }
/* Add multicast addresses */ /* Add multicast addresses */
netdev_for_each_mc_addr(ha, dev) { netdev_for_each_mc_addr(ha, dev) {
addrs = ha->addr; crc = ether_crc(ETH_ALEN, ha->addr);
if ((*addrs & 0x01) == 1) { /* multicast address? */ hashcode = (crc & 1); /* hashcode is 6 LSb of CRC ... */
crc = ether_crc(ETH_ALEN, addrs); for (j = 0; j < 5; j++) { /* ... in reverse order. */
hashcode = (crc & 1); /* hashcode is 6 LSb of CRC ... */ hashcode = (hashcode << 1) | ((crc >>= 1) & 1);
for (j = 0; j < 5; j++) { /* ... in reverse order. */
hashcode = (hashcode << 1) | ((crc >>= 1) & 1);
}
byte = hashcode >> 3; /* bit[3-5] -> byte in filter */
bit = 1 << (hashcode & 0x07); /* bit[0-2] -> bit in byte */
lp->init_block.mcast_table[byte] |= bit;
} }
byte = hashcode >> 3; /* bit[3-5] -> byte in filter */
bit = 1 << (hashcode & 0x07); /* bit[0-2] -> bit in byte */
lp->init_block.mcast_table[byte] |= bit;
} }
} }
} }