redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

iommu/mediatek: Check for NULL instead of IS_ERR() 

of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: 0df4fabe20 ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
hifive-unleashed-5.1
Dan Carpenter 2016-03-02 13:10:27 +03:00 committed by Joerg Roedel
parent 0b6c0ad3cf
commit 3189e4905c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/iommu/mtk_iommu.c
View File

@ -627,7 +627,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
plarbdev = of_platform_device_create(
larbnode, NULL,
platform_bus_type.dev_root);
if (IS_ERR(plarbdev))
if (!plarbdev)
return -EPROBE_DEFER;
}
data->smi_imu.larb_imu[i].dev = &plarbdev->dev;
@ -720,8 +720,8 @@ static int mtk_iommu_init_fn(struct device_node *np)
struct platform_device *pdev;
pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
if (IS_ERR(pdev))
return PTR_ERR(pdev);
if (!pdev)
return -ENOMEM;
ret = platform_driver_register(&mtk_iommu_driver);
if (ret) {