redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

V4L/DVB (3488): Snd_cx88_create: don't dereference NULL core 

If the call to cx88_core_get returns a NULL value, it is dereferenced
by cx88_reset, and perhaps by cx88_core_put.  Spotted by the Coverity
checker.

Signed-off-by: Duncan Sands <baldrick@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
hifive-unleashed-5.1
Duncan Sands 2006-03-14 12:12:39 -03:00 committed by Linus Torvalds
parent ae24601b47
commit 31dcbf994b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/video/cx88/cx88-alsa.c
View File

@ -672,6 +672,11 @@ static int __devinit snd_cx88_create(snd_card_t *card, struct pci_dev *pci,
chip = (snd_cx88_card_t *) card->private_data;
core = cx88_core_get(pci);
if (NULL == core) {
err = -EINVAL;
kfree (chip);
return err;
}
if (!pci_dma_supported(pci,0xffffffff)) {
dprintk(0, "%s/1: Oops: no 32bit PCI DMA ???\n",core->name);
@ -688,11 +693,6 @@ static int __devinit snd_cx88_create(snd_card_t *card, struct pci_dev *pci,
spin_lock_init(&chip->reg_lock);
cx88_reset(core);
if (NULL == core) {
err = -EINVAL;
kfree (chip);
return err;
}
chip->core = core;
/* get irq */