redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

iio: maxim_thermocouple: detect invalid storage size in read() 

As found by gcc -Wmaybe-uninitialized, having a storage_bytes value other
than 2 or 4 will result in undefined behavior:

drivers/iio/temperature/maxim_thermocouple.c: In function 'maxim_thermocouple_read':
drivers/iio/temperature/maxim_thermocouple.c:141:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This probably cannot happen, but returning -EINVAL here is appropriate
and makes gcc happy and the code more robust.

Fixes: 231147ee77 ("iio: maxim_thermocouple: Align 16 bit big endian value of raw reads")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
hifive-unleashed-5.1
Arnd Bergmann 2016-10-25 17:55:04 +02:00 committed by Jonathan Cameron
parent 3089ec2c10
commit 32cb7d27e6
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/iio/temperature/maxim_thermocouple.c
View File

@ -137,6 +137,8 @@ static int maxim_thermocouple_read(struct maxim_thermocouple_data *data,
case 4:
*val = be32_to_cpu(buf);
break;
default:
ret = -EINVAL;
}
/* check to be sure this is a valid reading */