redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

x86, setup: preemptively save/restore edi and ebp around INT 15 E820 

Impact: BIOS bugproofing

Since there are BIOSes known to clobber %ebx and %esi for INT 15 E820,
assume there is something out there clobbering %edi and/or %ebp too,
and don't wait for it to fail.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
hifive-unleashed-5.1
H. Peter Anvin 2009-03-28 13:53:26 -07:00
parent 01522df346
commit 32ec7fd08b
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
arch/x86/boot/memory.c
View File

@ -20,7 +20,7 @@ static int detect_memory_e820(void)
{
int count = 0;
u32 next = 0;
u32 size, id;
u32 size, id, edi;
u8 err;
struct e820entry *desc = boot_params.e820_map;
@ -29,10 +29,11 @@ static int detect_memory_e820(void)
/* Important: %edx and %esi are clobbered by some BIOSes,
so they must be either used for the error output
or explicitly marked clobbered. */
asm("int $0x15; setc %0"
or explicitly marked clobbered. Given that, assume there
is something out there clobbering %ebp and %edi, too. */
asm("pushl %%ebp; int $0x15; popl %%ebp; setc %0"
: "=d" (err), "+b" (next), "=a" (id), "+c" (size),
"=m" (*desc)
"=D" (edi), "=m" (*desc)
: "D" (desc), "d" (SMAP), "a" (0xe820)
: "esi");