redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

gpio/ml-ioh: fix off-by-one for displaying variable i in dev_err 

with the "for (; i != 0; i--)" sytax, i-- will be executed after the iteration.
thus dev_err shows wrong i value.
Switch to "while(--i >= 0)" which is better in readability.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
hifive-unleashed-5.1
Axel Lin 2011-06-14 19:12:57 +08:00 committed by Grant Likely
parent a57339b4b5
commit 33300571b1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpio-ml-ioh.c
View File

@ -233,7 +233,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
return 0;
err_gpiochip_add:
for (; i != 0; i--) {
while (--i >= 0) {
chip--;
ret = gpiochip_remove(&chip->gpio);
if (ret)