redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

ASoC: qdsp6: q6asm-dai: Fix a NULL vs IS_ERR() bug 

The q6asm_audio_client_alloc() doesn't return NULL, it returns error
pointers.

Fixes: 22930c79ac ("ASoC: qdsp6: q6asm-dai: Add support to compress offload")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
hifive-unleashed-5.1
Dan Carpenter 2018-12-21 12:05:16 +03:00 committed by Mark Brown
parent eef08e5350
commit 3391034e18
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/qcom/qdsp6/q6asm-dai.c
View File

@ -570,10 +570,11 @@ static int q6asm_dai_compr_open(struct snd_compr_stream *stream)
prtd->audio_client = q6asm_audio_client_alloc(dev,
(q6asm_cb)compress_event_handler,
prtd, stream_id, LEGACY_PCM_MODE);
if (!prtd->audio_client) {
if (IS_ERR(prtd->audio_client)) {
dev_err(dev, "Could not allocate memory\n");
ret = PTR_ERR(prtd->audio_client);
kfree(prtd);
return -ENOMEM;
return ret;
}
size = COMPR_PLAYBACK_MAX_FRAGMENT_SIZE *