redonkable/alistair23-linux
redonkable/alistair23-linux
1
0
Fork 0
Code Releases Activity

Input: aiptek - kill aiptek_convert_from_2s_complement()

Browse source 
There is no reason to do that, just tell the compiler that
we are dealing with signed values in buffer, that's it.

Signed-off-by: Rene van Paassen <rene.vanpaassen@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Dmitry Torokhov 2007-05-21 00:18:08 -04:00
parent cd438a58c8
commit 37767b66ed
1 changed files with 2 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
drivers/input/tablet/aiptek.c
View file

@ -376,26 +376,6 @@ static const char *map_val_to_str(const struct aiptek_map *map, int val)
return "unknown";
}
/***********************************************************************
* Relative reports deliver values in 2's complement format to
* deal with negative offsets.
*/
static int aiptek_convert_from_2s_complement(unsigned char c)
{
int ret;
unsigned char b = c;
int negate = 0;
if ((b & 0x80) != 0) {
b = ~b;
b--;
negate = 1;
}
ret = b;
ret = (negate == 1) ? -ret : ret;
return ret;
}
/***********************************************************************
* aiptek_irq can receive one of six potential reports.
* The documentation for each is in the body of the function.
@ -473,8 +453,8 @@ static void aiptek_irq(struct urb *urb)
aiptek->diagnostic =
AIPTEK_DIAGNOSTIC_SENDING_RELATIVE_IN_ABSOLUTE;
} else {
x = aiptek_convert_from_2s_complement(data[2]);
y = aiptek_convert_from_2s_complement(data[3]);
x = (signed char) data[2];
y = (signed char) data[3];
/* jitterable keeps track of whether any button has been pressed.
* We're also using it to remap the physical mouse button mask