redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

Revert "ALSA: hda - drop def association and sequence from pinconf comparing" 

This reverts commit c687200b9d.

Dropping the def association and sequence from pinconf comparing is a
bit risky, It will introduce a greater risk of catching unwanted
machines.

And in addition, so far no BIOS experts give us an explicit answer
whether it makes senses to compare these two fields or not.

For safety reason, we revert this commit.

Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
hifive-unleashed-5.1
Hui Wang 2014-05-29 15:59:17 +08:00 committed by Takashi Iwai
parent 396178370b
commit 37df09492c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sound/pci/hda/hda_auto_parser.c
View File

@ -844,8 +844,7 @@ static bool pin_config_match(struct hda_codec *codec,
{
for (; pins->nid; pins++) {
u32 def_conf = snd_hda_codec_get_pincfg(codec, pins->nid);
u32 mask = 0xffffff00;
if ((pins->val & mask) != (def_conf & mask))
if (pins->val != def_conf)
return false;
}
return true;