cpuidle: fix error handling in __cpuidle_register_device
Fix the error handling in __cpuidle_register_device to include the missing list_del. Move it to a label, which will simplify the error handling when coupled states are added. Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Tested-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Reviewed-by: Kevin Hilman <khilman@ti.com> Tested-by: Kevin Hilman <khilman@ti.com> Signed-off-by: Colin Cross <ccross@android.com> Reviewed-by: Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by: Len Brown <len.brown@intel.com>hifive-unleashed-5.1
parent
56cfbf74a1
commit
3af272ab75
|
@ -403,13 +403,18 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
|
||||||
|
|
||||||
per_cpu(cpuidle_devices, dev->cpu) = dev;
|
per_cpu(cpuidle_devices, dev->cpu) = dev;
|
||||||
list_add(&dev->device_list, &cpuidle_detected_devices);
|
list_add(&dev->device_list, &cpuidle_detected_devices);
|
||||||
if ((ret = cpuidle_add_sysfs(cpu_dev))) {
|
ret = cpuidle_add_sysfs(cpu_dev);
|
||||||
module_put(cpuidle_driver->owner);
|
if (ret)
|
||||||
return ret;
|
goto err_sysfs;
|
||||||
}
|
|
||||||
|
|
||||||
dev->registered = 1;
|
dev->registered = 1;
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
|
err_sysfs:
|
||||||
|
list_del(&dev->device_list);
|
||||||
|
per_cpu(cpuidle_devices, dev->cpu) = NULL;
|
||||||
|
module_put(cpuidle_driver->owner);
|
||||||
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in New Issue