redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity

Btrfs: use args in the correct order for kcalloc in btrfsic_read_block 

kcalloc is defined as:

  kcalloc(size_t n, size_t size, gfp_t flags)

Although this won't cause problems in practice, btrfsic_read_block()
uses kcalloc with n and size in the opposite order.

Reviewed-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
hifive-unleashed-5.1
Liu Bo 2018-09-08 04:41:40 +08:00 committed by David Sterba
parent a27a94c2b0
commit 3b2fd80160
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/btrfs/check-integrity.c
View File

@ -1594,6 +1594,7 @@ static int btrfsic_read_block(struct btrfsic_state *state,
{
unsigned int num_pages;
unsigned int i;
size_t size;
u64 dev_bytenr;
int ret;
@ -1608,9 +1609,8 @@ static int btrfsic_read_block(struct btrfsic_state *state,
num_pages = (block_ctx->len + (u64)PAGE_SIZE - 1) >>
PAGE_SHIFT;
block_ctx->mem_to_free = kcalloc(sizeof(*block_ctx->datav) +
sizeof(*block_ctx->pagev),
num_pages, GFP_NOFS);
size = sizeof(*block_ctx->datav) + sizeof(*block_ctx->pagev);
block_ctx->mem_to_free = kcalloc(num_pages, size, GFP_NOFS);
if (!block_ctx->mem_to_free)
return -ENOMEM;
block_ctx->datav = block_ctx->mem_to_free;